two minor modifications, inspired by the review of 
Refs https://github.com/Edirom/Edirom-Online-Backend/pull/2

add dependency update

dependabot[bot] authored 1 month ago and Daniel Roewenstrunk committed 1 month ago

Bumps [ncipollo/release-action](https://github.com/ncipollo/release-action) from 1.15.0 to 1.16.0.
- [Release notes](https://github.com/ncipollo/release-action/releases)
- [Commits](https://github.com/ncipollo/release-action/compare/v1.15.0...v1.16.0

)

---
updated-dependencies:
- dependency-name: ncipollo/release-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

krHERO authored 1 month ago and Daniel Roewenstrunk committed 1 month ago

this commit supplements the options how to capture annotations to the data package, so Edirom-Online is able to read them correctly.

Refs https://github.com/Edirom/Edirom-Online/issues/538

fixes #529

## Description, Context and related Issue

There surfaced two issues when testing with the Open-Faust data which
might be connected to #460.
1. JSONification of the `local:getAnnotations` function was not
complete. The function returned a map object `plist` as string, causing
some Javascript function to fail.
2. `teitext:getLabel#2` would return a sequence of strings (under some
circumstances) which was not allowed by the return value of the function
signature.

<!--- This project only accepts pull requests related to open issues.
Please link to the issue here: -->
Refs #460


## Types of changes
- Bug fix (non-breaking change which fixes an issue)
- Improvement
- Refactoring

## Overview
- I have performed a self-review of my code, according to the [style
guide](https://github.com/Edirom/Edirom-Online/blob/develop/STYLE-GUIDE.md)
- I have read the
[CONTRIBUTING](https://github.com/Edirom/Edirom-Online/blob/develop/CONTRIBUTING.md)
document.
- All new and existing tests passed.

to make use of the canonical function `eutil:getLocalizedTitle#2`

and apply some minor updates to documentation and code

to allow the empty sequence as return value

## Description, Context and related Issue

The function `edition:details($uri)?name` would return an element node
instead of a string value, thus the endpoint `getEdition.xql` returns
e.g. `"name" : "<editionName
xmlns=\"http://www.edirom.de/ns/1.3\">Pintos-Edirom von Salome
Obert</editionName>"` (among other properties).

This PR fixes this to return only the string value and refactors another
function to not duplicate code.

## Steps to reproduce 

Check the Ajax request to `getEdition.xql` which is loaded at every star
of the Edirom:
<img width="1512" alt="Bildschirmfoto 2025-01-14 um 18 41 29"
src="https://github.com/user-attachments/assets/ea67eac0-4d52-4f54-b5a2-0bd13ada1e97"
/>
(The screenshot already displays the fixed version)

## How Has This Been Tested?
With the Pintos data

## Types of changes
- Bug fix (non-breaking change which fixes an issue)
- Improvement
- Refactoring

## Overview
- I have updated the inline documentation accordingly.
- I have performed a self-review of my code, according to the [style
guide](https://github.com/Edirom/Edirom-Online/blob/develop/STYLE-GUIDE.md)
- I have read the
[CONTRIBUTING](https://github.com/Edirom/Edirom-Online/blob/develop/CONTRIBUTING.md)
document.
- All new and existing tests passed.

the getPreference would only check the URL parameter and not the actual
preferences for the key "application_language". This resulted in an
always-English frontend independent of the preferences set in the prefs
file.

The issue was reported by @obertsalome and can be reproduced with the
current Pintos data by simply starting the Edirom without any URL
parameter. This will show the frontend GUI elements in English although
the "application_language" is set to "de".


## Types of changes
- Bug fix (non-breaking change which fixes an issue)
- Improvement

## Overview
- I have performed a self-review of my code, according to the [style
guide](https://github.com/Edirom/Edirom-Online/blob/develop/STYLE-GUIDE.md)
- I have read the
[CONTRIBUTING](https://github.com/Edirom/Edirom-Online/blob/develop/CONTRIBUTING.md)
document.
- All new and existing tests passed.

to not duplicate code this function now simply points at `edition:details($uri)?name`

apply string normalization to enforce a string value to be returned (instead of an element node).

the getPreference would only check the URL parameter and not the actual preferences for the key "application_language".
This resulted in an always-English frontend independent of the preferences set in the prefs file

Co-Authored-By: Daniel Röwenstrunk <929533+roewenstrunk@users.noreply.github.com>

Bumps
[ncipollo/release-action](https://github.com/ncipollo/release-action)
from 1.14.0 to 1.15.0.

in the Pintos there's a siglum encoded like
```xml
<add xml:id="x38284ce9-f2be-4ca6-a8cb-227d85357ae1" place="rightmar" type="siglum">
    <rend xml:id="x9bbd3666-54ac-4287-b7f7-1d19347c7e14" color="red">Classe III.
        <lb xml:id="x7e7c09da-9ed9-4ed4-9339-75a18868a860"/>Band
        <lb xml:id="xd18991b0-bc11-447b-881a-b732d8f3b3c4"/>V. No. <rend xml:id="x4904459c-a4c4-40a9-beb5-d9f3c21ddeca" rend="underline">80</rend>.</rend>
</add>
```
which features multiple text nodes causing the original function `source:getSiglum#1` to fail.

when $eventualTitles is the empty sequence.

Bumps [ncipollo/release-action](https://github.com/ncipollo/release-action) from 1.14.0 to 1.15.0.
- [Release notes](https://github.com/ncipollo/release-action/releases)
- [Commits](https://github.com/ncipollo/release-action/compare/v1.14.0...v1.15.0

)

---
updated-dependencies:
- dependency-name: ncipollo/release-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

## Description, Context and related Issue

Remove `mei:titleStmt` when determining the title of the work because in
MEI 5 `mei:title` is a direct child of `mei:work`
Closes #337 

## How Has This Been Tested?

With a BAZ-GA MEI 5 work.

## Types of changes

- Bug fix (non-breaking change which fixes an issue)

## Overview
<!--- Go over all the following points, and DELETE options that are not
relevant. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
- I have performed a self-review of my code, according to the [style
guide](https://github.com/Edirom/Edirom-Online/blob/develop/STYLE-GUIDE.md)
- I have read the
[CONTRIBUTING](https://github.com/Edirom/Edirom-Online/blob/develop/CONTRIBUTING.md)
document.
- I have added tests to cover my changes at
[testing](https://github.com/Edirom/Edirom-Online/tree/develop/testing)

- All new and existing tests passed.
--> will know when the PR has run its tests ;-)

Daniel Roewenstrunk authored 2 months ago and Peter Stadler committed 2 months ago

Co-authored-by: Peter Stadler <stadlerpeter@yahoo.fr>

since the return value of `eutil:getDoc#1` in https://github.com/Edirom/Edirom-Online/blob/babd1c6076ba58214b85a9891c3c2215d9d1c9d6/add/data/xql/getLinkTarget.xql#L278 might be the empty sequence this should be reflected in the function signatures that consume this $doc variable.

bwbohl authored 3 months ago and Peter Stadler committed 2 months ago

Thsi removes doubled 'type' identification that already happens in the $type variable which gets submitted to the call of the getWindowTitle function