when $eventualTitles is the empty sequence.

## Description, Context and related Issue

Remove `mei:titleStmt` when determining the title of the work because in
MEI 5 `mei:title` is a direct child of `mei:work`
Closes #337 

## How Has This Been Tested?

With a BAZ-GA MEI 5 work.

## Types of changes

- Bug fix (non-breaking change which fixes an issue)

## Overview
<!--- Go over all the following points, and DELETE options that are not
relevant. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
- I have performed a self-review of my code, according to the [style
guide](https://github.com/Edirom/Edirom-Online/blob/develop/STYLE-GUIDE.md)
- I have read the
[CONTRIBUTING](https://github.com/Edirom/Edirom-Online/blob/develop/CONTRIBUTING.md)
document.
- I have added tests to cover my changes at
[testing](https://github.com/Edirom/Edirom-Online/tree/develop/testing)

- All new and existing tests passed.
--> will know when the PR has run its tests ;-)

Daniel Roewenstrunk authored 3 months ago and Peter Stadler committed 3 months ago

Co-authored-by: Peter Stadler <stadlerpeter@yahoo.fr>

since the return value of `eutil:getDoc#1` in https://github.com/Edirom/Edirom-Online/blob/babd1c6076ba58214b85a9891c3c2215d9d1c9d6/add/data/xql/getLinkTarget.xql#L278 might be the empty sequence this should be reflected in the function signatures that consume this $doc variable.

bwbohl authored 3 months ago and Peter Stadler committed 3 months ago

Thsi removes doubled 'type' identification that already happens in the $type variable which gets submitted to the call of the getWindowTitle function

bwbohl authored 3 months ago and Peter Stadler committed 3 months ago

be aware that this will fail for MEI prior v4

krHERO authored 3 months ago and Daniel Roewenstrunk committed 3 months ago

this commit adds a prominent link in the readme to the wiki where the community meeting information is captured. so this could be an extra opportunity for people that might struggle with the workflow how to create content to place questions and discussions at the community meetings

Refs https://github.com/Edirom/Edirom-Online/issues/517

krHERO authored 3 months ago and Daniel Roewenstrunk committed 3 months ago

Refs https://github.com/Edirom/Edirom-Online/issues/517

krHERO authored 3 months ago and Daniel Roewenstrunk committed 3 months ago

Refs https://github.com/Edirom/Edirom-Online/issues/517

krHERO authored 3 months ago and Daniel Roewenstrunk committed 3 months ago

this commit is a starting point for a workflow description to generate your data.

Refs https://github.com/Edirom/Edirom-Online/issues/517

krHERO authored 3 months ago and Daniel Roewenstrunk committed 3 months ago

minor add to the table of contents

Refs https://github.com/Edirom/Edirom-Online/issues/517

krHERO authored 3 months ago and Daniel Roewenstrunk committed 3 months ago

this commit adds information how provide the navigator with content.

Refs https://github.com/Edirom/Edirom-Online/issues/517

Peter Stadler authored 3 months ago and Daniel Roewenstrunk committed 3 months ago

the latest change in 4247d58d did not update the module imports

Peter Stadler authored 3 months ago and Daniel Roewenstrunk committed 3 months ago

and add tests. This will avoid function errors due to returning empty sequence instead of strings.

Co-Authored-By: Daniel Jettka <18614293+daniel-jettka@users.noreply.github.com>
Co-Authored-By: Daniel Röwenstrunk <929533+roewenstrunk@users.noreply.github.com>
Co-Authored-By: krHERO <krHERO@users.noreply.github.com>

Edirom Online failed if no cookie 'edirom-language' was set because pref 'application_language' was called before preferences were set. this commit is a quick fix, which returns default lang 'en' if 'application_language' could not be found.
* also removing cookie-handling for 'edirom_language'
Refs #504

this commit adds two links for clarinet quintet: release version of edirom, and data-repository

* build: separate copying of help images from copy that applies token replacement

* reverted bootstrap.js

* adding about window statements

---------

Co-authored-by: bwbohl <b.w.bohl@gmail.com>

refs https://github.com/Edirom/Edirom-Online/issues/23

this commit adds a language variable for measure.

closes #24

## Description, Context and related Issue
* add parts to goto-menu in source view.
* add preference to change order from partwise to movementwise

Refs #13 
Refs #271 

## How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you
ran. -->
run in local Edirom-Online, tested with open-faust sources A2 (without
parts) and A3 (with parts).

## Types of changes
- New feature (non-breaking change which adds functionality)
- Improvement

## Overview
- I have updated the inline documentation accordingly.
- I have performed a self-review of my code, according to the [style
guide](https://github.com/Edirom/Edirom-Online/blob/develop/STYLE-GUIDE.md)
- I have read the
[CONTRIBUTING](https://github.com/Edirom/Edirom-Online/blob/develop/CONTRIBUTING.md)
document.

## Description, Context and related Issue
This PR replaces all direct calls to the `collection` function with the
new dedicated function `edition:collection#1` so all error handling,
improvements, etc. can be done at this central location.

This implements #437

## How Has This Been Tested?
Tested with clarinet quintet

## Types of changes
- Improvement
- Refactoring

## Overview
- I have performed a self-review of my code, according to the [style
guide](https://github.com/Edirom/Edirom-Online/blob/develop/STYLE-GUIDE.md)
- I have read the
[CONTRIBUTING](https://github.com/Edirom/Edirom-Online/blob/develop/CONTRIBUTING.md)
document.
- All new and existing tests passed.

if parts had no id, the parts menu would have been shown but not clickable because the parts could ne be referenced.
this prevents breaking for some sources.